feat: kubo 0.42, electron 42#3167
Open
lidel wants to merge 8 commits into
Open
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring alerts on:
|
Electron 42 no longer downloads its binary during postinstall, so unit/e2e tests that require('electron') in a Node context fail with a missing path.txt. Run electron's install-electron only in pretest hooks, keeping npm install lean for downstream packagers that use a system electron.
lidel
force-pushed
the
kubo-0.42-electron-42
branch
4 times, most recently
from
19fa4cb to
c034326
Compare
Electron 42 fetches its binary lazily on first bin run, so parallel Playwright workers each race install.js and leave path.txt absent. Pre-install once, serialized, in a pretest step that falls back to a forced fresh download (recovers a corrupt cache) and fails loudly if path.txt still does not appear.
Jobs had no timeout-minutes and defaulted toward GitHub's 6h limit, so a stuck step could hang for hours. Cap each job above its worst-case successful-run duration: webui 10m (~15s typical), test 15m (~2m typical), build 40m (ubuntu packaging+signing peaked at ~22m).
lidel
force-pushed
the
kubo-0.42-electron-42
branch
from
c034326 to
b20c9c2
Compare
The upgrade/error template only renders after kubo's startup attempt resolves, which is slow on CI (first run of a freshly downloaded binary, notably macOS), and it may appear in a reloaded or newly created prompt window. Poll every prompt window for the upgrade text with a budget-aligned timeout instead of binding to the first window and racing a fixed 45s wait.
Member
Author
|
@SocketSecurity ignore npm/js-yaml@4.2.0 Socket comments are false positive. Both alerts are Socket's
Both are well-known, widely-used packages and arrive only as dev/build dependencies, not runtime code shipped to users. |
electron-builder 26.14 swapped its native (app-builder-bin) icon converter for a wasm-vips one that cannot read our legacy JPEG2000 icon.icns when generating the Linux icon set, which fails the Linux build. Provide an explicit 512px linux.icon PNG (the idiomatic Linux setup) so electron-builder resizes the PNG directly and never converts the .icns; mac/win keep their icns/ico. Drop the now-unused install-electron script.
lidel
force-pushed
the
kubo-0.42-electron-42
branch
from
46b6f56 to
0b2da1a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.